Code Challenge 11 - Generators for Fun and Profit - Review

Posted by PyBites on Sat 25 March 2017 in Challenges • 2 min read

It's end of the week again so we review the code challenge of this week: Generators for Fun and Profit. It's never late to join, just fork us and start coding.

Our solution + learning

This was a pretty easy one, yet showing a powerful way to start thinking about generators as pipelines that can be plugged into each other.

Our solution is here. A couple of notes:

  • Here you see the 'plugged into each other' part:

    if __name__ == "__main__":
        files = gen_files('../*/*.py')
        lines = gen_lines(files)
        modules = gen_grep(lines, re.compile(r'^import (\w+)'))
  • iglob returns an iterator which yields the paths matching a pathname pattern, glob returns a list, also fine because we are not dealing with a lot of directories. You can also use os.walk but when you have a clear pattern (i)glob is less code.

  • We use yield from (>= 3.3) which saves a for loop (shorter).

  • As seen before use collections.Counter, it's hard to beat short- and conciseness:

    def gen_count(modules):
        yield from Counter(modules).most_common()
  • We use grouping to capture the match as discussed in our regex article:

    def gen_grep(lines, pattern):
        for line in lines:
            m = pattern.match(line.rstrip())
            if m:
                yield  # retrieves what's matched in parenthesis
    modules = gen_grep(lines, re.compile(r'^import (\w+)'))

Community branch

We got our first solution PR which we merged onto our community branch. This is a nice way to get credit and help our community learn more.

The solution was pretty similar to ours. One nice addition was to sort manually on both values and keys, most_common only sorts by values. Also the regex part was slightly different stripping off import with re.sub. It is nice to see different solutions to the same problem, you learn more.


Next week we do another game, so we expect some more complexity and variety in solutions. Stay tuned ...

Do you like these challenges?

We hope you are enjoying this. If we can do anything better or you have ideas please open a new issue or reach out to us. See you next week ...

>>> next(PyBites)

Get our 'Become a Better Python Developer' cheat sheet sent straight to your inbox by signing up for our Newsletter: